Commit 4d2fae8b authored by Alan Stern's avatar Alan Stern Committed by Greg Kroah-Hartman

USB: cypress_m8: remove invalid Clear-Halt

This patch (as1265) removes an erroneous call to usb_clear_halt from
the cypress_m8 driver.  The call isn't valid because it is made from
interrupt context whereas usb_clear_halt is a blocking routine.

Presumably the code has never been executed; if it did it would cause
an oops.  So instead treat -EPIPE like any other sort of unexplained
error.
Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1fe975f9
...@@ -1228,8 +1228,8 @@ static void cypress_read_int_callback(struct urb *urb) ...@@ -1228,8 +1228,8 @@ static void cypress_read_int_callback(struct urb *urb)
/* precursor to disconnect so just go away */ /* precursor to disconnect so just go away */
return; return;
case -EPIPE: case -EPIPE:
usb_clear_halt(port->serial->dev, 0x81); /* Can't call usb_clear_halt while in_interrupt */
break; /* FALLS THROUGH */
default: default:
/* something ugly is going on... */ /* something ugly is going on... */
dev_err(&urb->dev->dev, dev_err(&urb->dev->dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment