Commit 4e4f74a7 authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'locking-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull lockdep fix from Ingo Molnar:
 "This fixes an ugly lockdep stack trace output regression. (But also
  affects other stacktrace users such as kmemleak, KASAN, etc)"

* 'locking-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  stacktrace, lockdep: Fix address, newline ugliness
parents 21a7061c bfeda41d
...@@ -18,10 +18,8 @@ void print_stack_trace(struct stack_trace *trace, int spaces) ...@@ -18,10 +18,8 @@ void print_stack_trace(struct stack_trace *trace, int spaces)
if (WARN_ON(!trace->entries)) if (WARN_ON(!trace->entries))
return; return;
for (i = 0; i < trace->nr_entries; i++) { for (i = 0; i < trace->nr_entries; i++)
printk("%*c", 1 + spaces, ' '); printk("%*c%pS\n", 1 + spaces, ' ', (void *)trace->entries[i]);
print_ip_sym(trace->entries[i]);
}
} }
EXPORT_SYMBOL_GPL(print_stack_trace); EXPORT_SYMBOL_GPL(print_stack_trace);
...@@ -29,7 +27,6 @@ int snprint_stack_trace(char *buf, size_t size, ...@@ -29,7 +27,6 @@ int snprint_stack_trace(char *buf, size_t size,
struct stack_trace *trace, int spaces) struct stack_trace *trace, int spaces)
{ {
int i; int i;
unsigned long ip;
int generated; int generated;
int total = 0; int total = 0;
...@@ -37,9 +34,8 @@ int snprint_stack_trace(char *buf, size_t size, ...@@ -37,9 +34,8 @@ int snprint_stack_trace(char *buf, size_t size,
return 0; return 0;
for (i = 0; i < trace->nr_entries; i++) { for (i = 0; i < trace->nr_entries; i++) {
ip = trace->entries[i]; generated = snprintf(buf, size, "%*c%pS\n", 1 + spaces, ' ',
generated = snprintf(buf, size, "%*c[<%p>] %pS\n", (void *)trace->entries[i]);
1 + spaces, ' ', (void *) ip, (void *) ip);
total += generated; total += generated;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment