Commit 4f48ec8a authored by Markus Elfring's avatar Markus Elfring Committed by Rafael J. Wysocki

PM-wakeup: Delete unnecessary checks before three function calls

The following functions test whether their argument is NULL
and then return immediately.
 * dev_pm_arm_wake_irq
 * dev_pm_disarm_wake_irq
 * wakeup_source_unregister

Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
[ rjw: Minor whitespace adjustments ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent fe7450b0
...@@ -334,10 +334,9 @@ void device_wakeup_arm_wake_irqs(void) ...@@ -334,10 +334,9 @@ void device_wakeup_arm_wake_irqs(void)
struct wakeup_source *ws; struct wakeup_source *ws;
rcu_read_lock(); rcu_read_lock();
list_for_each_entry_rcu(ws, &wakeup_sources, entry) { list_for_each_entry_rcu(ws, &wakeup_sources, entry)
if (ws->wakeirq) dev_pm_arm_wake_irq(ws->wakeirq);
dev_pm_arm_wake_irq(ws->wakeirq);
}
rcu_read_unlock(); rcu_read_unlock();
} }
...@@ -351,10 +350,9 @@ void device_wakeup_disarm_wake_irqs(void) ...@@ -351,10 +350,9 @@ void device_wakeup_disarm_wake_irqs(void)
struct wakeup_source *ws; struct wakeup_source *ws;
rcu_read_lock(); rcu_read_lock();
list_for_each_entry_rcu(ws, &wakeup_sources, entry) { list_for_each_entry_rcu(ws, &wakeup_sources, entry)
if (ws->wakeirq) dev_pm_disarm_wake_irq(ws->wakeirq);
dev_pm_disarm_wake_irq(ws->wakeirq);
}
rcu_read_unlock(); rcu_read_unlock();
} }
...@@ -390,9 +388,7 @@ int device_wakeup_disable(struct device *dev) ...@@ -390,9 +388,7 @@ int device_wakeup_disable(struct device *dev)
return -EINVAL; return -EINVAL;
ws = device_wakeup_detach(dev); ws = device_wakeup_detach(dev);
if (ws) wakeup_source_unregister(ws);
wakeup_source_unregister(ws);
return 0; return 0;
} }
EXPORT_SYMBOL_GPL(device_wakeup_disable); EXPORT_SYMBOL_GPL(device_wakeup_disable);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment