Commit 5158ba3e authored by Russ Dill's avatar Russ Dill Committed by Steven Rostedt

ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP

When BISECT_REVERSE and BISECT_SKIP are used together with boot or test
testing, build failures are treated as boot or test failures and
'git bisect bad' is executed instead of 'git bisect skip'. This is because
the $ret value of -1 is treated as a build failure, but the $reverse_bisect
logic does not properly handle this.

Simple fix, only invert it if it is positive.

Link: http://lkml.kernel.org/r/1335235380-8509-1-git-send-email-Russ.Dill@ti.comSigned-off-by: default avatarRuss Dill <Russ.Dill@ti.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 66f75a5d
......@@ -2192,7 +2192,7 @@ sub run_bisect {
}
# Are we looking for where it worked, not failed?
if ($reverse_bisect) {
if ($reverse_bisect && $ret >= 0) {
$ret = !$ret;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment