Commit 52d304eb authored by NeilBrown's avatar NeilBrown Committed by Jeff Layton

locks: fix NULL-deref in generic_delete_lease

commit 0efaa7e8
  locks: generic_delete_lease doesn't need a file_lock at all

moves the call to fl->fl_lmops->lm_change() to a place in the
code where fl might be a non-lease lock.
When that happens, fl_lmops is NULL and an Oops ensures.

So add an extra test to restore correct functioning.
Reported-by: default avatarLinda Walsh <suse@tlinx.org>
Link: https://bugzilla.suse.com/show_bug.cgi?id=912569
Cc: stable@vger.kernel.org (v3.18)
Fixes: 0efaa7e8Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarJeff Layton <jlayton@primarydata.com>
parent 971780b7
...@@ -1702,7 +1702,7 @@ static int generic_delete_lease(struct file *filp) ...@@ -1702,7 +1702,7 @@ static int generic_delete_lease(struct file *filp)
break; break;
} }
trace_generic_delete_lease(inode, fl); trace_generic_delete_lease(inode, fl);
if (fl) if (fl && IS_LEASE(fl))
error = fl->fl_lmops->lm_change(before, F_UNLCK, &dispose); error = fl->fl_lmops->lm_change(before, F_UNLCK, &dispose);
spin_unlock(&inode->i_lock); spin_unlock(&inode->i_lock);
locks_dispose_list(&dispose); locks_dispose_list(&dispose);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment