Commit 53909030 authored by Quentin Monnet's avatar Quentin Monnet Committed by Daniel Borkmann

tools: bpftool: prevent infinite loop in get_fdinfo()

Function getline() returns -1 on failure to read a line, thus creating
an infinite loop in get_fdinfo() if the key is not found. Fix it by
calling the function only as long as we get a strictly positive return
value.

Found by copying the code for a key which is not always present...

Fixes: 71bb428f ("tools: bpf: add bpftool")
Signed-off-by: default avatarQuentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 49a249c3
...@@ -304,7 +304,7 @@ char *get_fdinfo(int fd, const char *key) ...@@ -304,7 +304,7 @@ char *get_fdinfo(int fd, const char *key)
return NULL; return NULL;
} }
while ((n = getline(&line, &line_n, fdi))) { while ((n = getline(&line, &line_n, fdi)) > 0) {
char *value; char *value;
int len; int len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment