Commit 547414d1 authored by NeilBrown's avatar NeilBrown

md/raid10: remove unnecessary smp_mb() from end_sync_write

Recent commit 4ca40c2c (md/raid10: Allow replacement device ...)
added an smp_mb in end_sync_write.
This was to close a possible race with raid10_remove_disk.
However there is no such race as it is never attempted to remove a
disk while resync (or recovery) is happening.
so the smp_mb is just noise.
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 1e3fa9bd
...@@ -1682,10 +1682,8 @@ static void end_sync_write(struct bio *bio, int error) ...@@ -1682,10 +1682,8 @@ static void end_sync_write(struct bio *bio, int error)
d = find_bio_disk(conf, r10_bio, bio, &slot, &repl); d = find_bio_disk(conf, r10_bio, bio, &slot, &repl);
if (repl) if (repl)
rdev = conf->mirrors[d].replacement; rdev = conf->mirrors[d].replacement;
if (!rdev) { else
smp_mb();
rdev = conf->mirrors[d].rdev; rdev = conf->mirrors[d].rdev;
}
if (!uptodate) { if (!uptodate) {
if (repl) if (repl)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment