Commit 55b35d07 authored by Suzuki K Poulose's avatar Suzuki K Poulose Committed by Catalin Marinas

arm64: Run enable method for errata work arounds on late CPUs

When a CPU is brought up after we have finalised the system
wide capabilities (i.e, features and errata), we make sure the
new CPU doesn't need a new errata work around which has not been
detected already. However we don't run enable() method on the new
CPU for the errata work arounds already detected. This could
cause the new CPU running without potential work arounds.
It is upto the "enable()" method to decide if this CPU should
do something about the errata.

Fixes: commit 6a6efbb4 ("arm64: Verify CPU errata work arounds on hotplugged CPU")
Cc: Will Deacon <will.deacon@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Andre Przywara <andre.przywara@arm.com>
Cc: Dave Martin <dave.martin@arm.com>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent a8e4c0a9
...@@ -373,15 +373,18 @@ void verify_local_cpu_errata_workarounds(void) ...@@ -373,15 +373,18 @@ void verify_local_cpu_errata_workarounds(void)
{ {
const struct arm64_cpu_capabilities *caps = arm64_errata; const struct arm64_cpu_capabilities *caps = arm64_errata;
for (; caps->matches; caps++) for (; caps->matches; caps++) {
if (!cpus_have_cap(caps->capability) && if (cpus_have_cap(caps->capability)) {
caps->matches(caps, SCOPE_LOCAL_CPU)) { if (caps->enable)
caps->enable((void *)caps);
} else if (caps->matches(caps, SCOPE_LOCAL_CPU)) {
pr_crit("CPU%d: Requires work around for %s, not detected" pr_crit("CPU%d: Requires work around for %s, not detected"
" at boot time\n", " at boot time\n",
smp_processor_id(), smp_processor_id(),
caps->desc ? : "an erratum"); caps->desc ? : "an erratum");
cpu_die_early(); cpu_die_early();
} }
}
} }
void update_cpu_errata_workarounds(void) void update_cpu_errata_workarounds(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment