Commit 56780940 authored by Leo (Sunpeng) Li's avatar Leo (Sunpeng) Li Committed by Alex Deucher

drm/amd/display: Remove redundant non-zero and overflow check

[Why]
Unsigned int is guaranteed to be >= 0, and read_channel_reply checks for
overflows. read_channel_reply also returns -1 on error, which is what
dc_link_aux_transfer is expected to return on error.

[How]
Remove the if-statement. Return result of read_channel_reply directly.
Signed-off-by: default avatarLeo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: default avatarMikita Lipski <Mikita.Lipski@amd.com>
Acked-by: default avatarLeo Li <sunpeng.li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2f14bc89
...@@ -666,13 +666,9 @@ int dc_link_aux_transfer(struct ddc_service *ddc, ...@@ -666,13 +666,9 @@ int dc_link_aux_transfer(struct ddc_service *ddc,
switch (operation_result) { switch (operation_result) {
case AUX_CHANNEL_OPERATION_SUCCEEDED: case AUX_CHANNEL_OPERATION_SUCCEEDED:
res = returned_bytes; res = aux_engine->funcs->read_channel_reply(aux_engine, size,
buffer, reply,
if (res <= size && res >= 0) &status);
res = aux_engine->funcs->read_channel_reply(aux_engine, size,
buffer, reply,
&status);
break; break;
case AUX_CHANNEL_OPERATION_FAILED_HPD_DISCON: case AUX_CHANNEL_OPERATION_FAILED_HPD_DISCON:
res = 0; res = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment