Commit 56cb31e1 authored by Stefan Bühler's avatar Stefan Bühler Committed by Johannes Berg

cfg80211: fix double-free after changing network namespace

If wdev->wext.keys was initialized it didn't get reset to NULL on
unregister (and it doesn't get set in cfg80211_init_wdev either), but
wdev is reused if unregister was triggered through
cfg80211_switch_netns.

The next unregister (for whatever reason) will try to free
wdev->wext.keys again.
Signed-off-by: default avatarStefan Bühler <source@stbuehler.de>
Link: https://lore.kernel.org/r/20191126100543.782023-1-stefan.buehler@tik.uni-stuttgart.deSigned-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 753ffad3
...@@ -1102,6 +1102,7 @@ static void __cfg80211_unregister_wdev(struct wireless_dev *wdev, bool sync) ...@@ -1102,6 +1102,7 @@ static void __cfg80211_unregister_wdev(struct wireless_dev *wdev, bool sync)
#ifdef CONFIG_CFG80211_WEXT #ifdef CONFIG_CFG80211_WEXT
kzfree(wdev->wext.keys); kzfree(wdev->wext.keys);
wdev->wext.keys = NULL;
#endif #endif
/* only initialized if we have a netdev */ /* only initialized if we have a netdev */
if (wdev->netdev) if (wdev->netdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment