Commit 58b7450d authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab

[media] m88ds3103: remove unneeded AGC from inittab

Optimal AGC is highly depended on used RF tuner and due to that
it is already included to chip configuration. However, inittab
has default AGC value, which was later replaced by one from config.

Add also comment to all chip configuration options about default
values and if those are needed to set or not.
Reported-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent c19314b0
...@@ -26,26 +26,28 @@ ...@@ -26,26 +26,28 @@
struct m88ds3103_config { struct m88ds3103_config {
/* /*
* I2C address * I2C address
* Default: none, must set
* 0x68, ... * 0x68, ...
*/ */
u8 i2c_addr; u8 i2c_addr;
/* /*
* clock * clock
* Default: none, must set
* 27000000 * 27000000
*/ */
u32 clock; u32 clock;
/* /*
* max bytes I2C provider is asked to write at once * max bytes I2C provider is asked to write at once
* Note: Buffer is taken from the stack currently! * Default: none, must set
* Value must be set.
* 33, 65, ... * 33, 65, ...
*/ */
u16 i2c_wr_max; u16 i2c_wr_max;
/* /*
* TS output mode * TS output mode
* Default: M88DS3103_TS_SERIAL
*/ */
#define M88DS3103_TS_SERIAL 0 /* TS output pin D0, normal */ #define M88DS3103_TS_SERIAL 0 /* TS output pin D0, normal */
#define M88DS3103_TS_SERIAL_D7 1 /* TS output pin D7 */ #define M88DS3103_TS_SERIAL_D7 1 /* TS output pin D7 */
...@@ -58,16 +60,19 @@ struct m88ds3103_config { ...@@ -58,16 +60,19 @@ struct m88ds3103_config {
/* /*
* spectrum inversion * spectrum inversion
* Default: 0
*/ */
u8 spec_inv:1; u8 spec_inv:1;
/* /*
* AGC polarity * AGC polarity
* Default: 0
*/ */
u8 agc_inv:1; u8 agc_inv:1;
/* /*
* clock output * clock output
* Default: M88DS3103_CLOCK_OUT_DISABLED
*/ */
#define M88DS3103_CLOCK_OUT_DISABLED 0 #define M88DS3103_CLOCK_OUT_DISABLED 0
#define M88DS3103_CLOCK_OUT_ENABLED 1 #define M88DS3103_CLOCK_OUT_ENABLED 1
...@@ -76,9 +81,14 @@ struct m88ds3103_config { ...@@ -76,9 +81,14 @@ struct m88ds3103_config {
/* /*
* DiSEqC envelope mode * DiSEqC envelope mode
* Default: 0
*/ */
u8 envelope_mode:1; u8 envelope_mode:1;
/*
* AGC configuration
* Default: none, must set
*/
u8 agc; u8 agc;
}; };
......
...@@ -57,7 +57,6 @@ static const struct m88ds3103_reg_val m88ds3103_dvbs_init_reg_vals[] = { ...@@ -57,7 +57,6 @@ static const struct m88ds3103_reg_val m88ds3103_dvbs_init_reg_vals[] = {
{0x30, 0x08}, {0x30, 0x08},
{0x31, 0x40}, {0x31, 0x40},
{0x32, 0x32}, {0x32, 0x32},
{0x33, 0x35},
{0x35, 0xff}, {0x35, 0xff},
{0x3a, 0x00}, {0x3a, 0x00},
{0x37, 0x10}, {0x37, 0x10},
...@@ -139,7 +138,6 @@ static const struct m88ds3103_reg_val m88ds3103_dvbs2_init_reg_vals[] = { ...@@ -139,7 +138,6 @@ static const struct m88ds3103_reg_val m88ds3103_dvbs2_init_reg_vals[] = {
{0x27, 0x31}, {0x27, 0x31},
{0x30, 0x08}, {0x30, 0x08},
{0x32, 0x32}, {0x32, 0x32},
{0x33, 0x35},
{0x35, 0xff}, {0x35, 0xff},
{0x3a, 0x00}, {0x3a, 0x00},
{0x37, 0x10}, {0x37, 0x10},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment