Commit 58d876fa authored by Dan Carpenter's avatar Dan Carpenter Committed by Michael Ellerman

cxl: Unlock on error in probe

We should unlock if get_cxl_adapter() fails.

Fixes: 594ff7d0 ("cxl: Support to flash a new image on the adapter from a guest")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFrederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 4386c096
...@@ -401,8 +401,10 @@ static int device_open(struct inode *inode, struct file *file) ...@@ -401,8 +401,10 @@ static int device_open(struct inode *inode, struct file *file)
if (down_interruptible(&sem) != 0) if (down_interruptible(&sem) != 0)
return -EPERM; return -EPERM;
if (!(adapter = get_cxl_adapter(adapter_num))) if (!(adapter = get_cxl_adapter(adapter_num))) {
return -ENODEV; rc = -ENODEV;
goto err_unlock;
}
file->private_data = adapter; file->private_data = adapter;
continue_token = 0; continue_token = 0;
...@@ -446,6 +448,8 @@ static int device_open(struct inode *inode, struct file *file) ...@@ -446,6 +448,8 @@ static int device_open(struct inode *inode, struct file *file)
free_page((unsigned long) le); free_page((unsigned long) le);
err: err:
put_device(&adapter->dev); put_device(&adapter->dev);
err_unlock:
up(&sem);
return rc; return rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment