Commit 59361e99 authored by Paul Burton's avatar Paul Burton

MIPS: bitops: Use MIPS_ISA_REV, not #ifdefs

Rather than #ifdef on CONFIG_CPU_* to determine whether the ins
instruction is supported we can simply check MIPS_ISA_REV to discover
whether we're targeting MIPSr2 or higher. Do so in order to clean up the
code.
Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
Cc: Huacai Chen <chenhc@lemote.com>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-kernel@vger.kernel.org
parent 3d2920cf
...@@ -19,6 +19,7 @@ ...@@ -19,6 +19,7 @@
#include <asm/byteorder.h> /* sigh ... */ #include <asm/byteorder.h> /* sigh ... */
#include <asm/compiler.h> #include <asm/compiler.h>
#include <asm/cpu-features.h> #include <asm/cpu-features.h>
#include <asm/isa-rev.h>
#include <asm/llsc.h> #include <asm/llsc.h>
#include <asm/sgidefs.h> #include <asm/sgidefs.h>
#include <asm/war.h> #include <asm/war.h>
...@@ -76,8 +77,7 @@ static inline void set_bit(unsigned long nr, volatile unsigned long *addr) ...@@ -76,8 +77,7 @@ static inline void set_bit(unsigned long nr, volatile unsigned long *addr)
return; return;
} }
#if defined(CONFIG_CPU_MIPSR2) || defined(CONFIG_CPU_MIPSR6) if ((MIPS_ISA_REV >= 2) && __builtin_constant_p(bit) && (bit >= 16)) {
if (__builtin_constant_p(bit) && (bit >= 16)) {
loongson_llsc_mb(); loongson_llsc_mb();
do { do {
__asm__ __volatile__( __asm__ __volatile__(
...@@ -90,7 +90,6 @@ static inline void set_bit(unsigned long nr, volatile unsigned long *addr) ...@@ -90,7 +90,6 @@ static inline void set_bit(unsigned long nr, volatile unsigned long *addr)
} while (unlikely(!temp)); } while (unlikely(!temp));
return; return;
} }
#endif /* CONFIG_CPU_MIPSR2 || CONFIG_CPU_MIPSR6 */
loongson_llsc_mb(); loongson_llsc_mb();
do { do {
...@@ -143,8 +142,7 @@ static inline void clear_bit(unsigned long nr, volatile unsigned long *addr) ...@@ -143,8 +142,7 @@ static inline void clear_bit(unsigned long nr, volatile unsigned long *addr)
return; return;
} }
#if defined(CONFIG_CPU_MIPSR2) || defined(CONFIG_CPU_MIPSR6) if ((MIPS_ISA_REV >= 2) && __builtin_constant_p(bit)) {
if (__builtin_constant_p(bit)) {
loongson_llsc_mb(); loongson_llsc_mb();
do { do {
__asm__ __volatile__( __asm__ __volatile__(
...@@ -157,7 +155,6 @@ static inline void clear_bit(unsigned long nr, volatile unsigned long *addr) ...@@ -157,7 +155,6 @@ static inline void clear_bit(unsigned long nr, volatile unsigned long *addr)
} while (unlikely(!temp)); } while (unlikely(!temp));
return; return;
} }
#endif /* CONFIG_CPU_MIPSR2 || CONFIG_CPU_MIPSR6 */
loongson_llsc_mb(); loongson_llsc_mb();
do { do {
...@@ -377,8 +374,7 @@ static inline int test_and_clear_bit(unsigned long nr, ...@@ -377,8 +374,7 @@ static inline int test_and_clear_bit(unsigned long nr,
: "=&r" (temp), "+" GCC_OFF_SMALL_ASM() (*m), "=&r" (res) : "=&r" (temp), "+" GCC_OFF_SMALL_ASM() (*m), "=&r" (res)
: "r" (1UL << bit) : "r" (1UL << bit)
: __LLSC_CLOBBER); : __LLSC_CLOBBER);
#if defined(CONFIG_CPU_MIPSR2) || defined(CONFIG_CPU_MIPSR6) } else if ((MIPS_ISA_REV >= 2) && __builtin_constant_p(nr)) {
} else if (__builtin_constant_p(nr)) {
loongson_llsc_mb(); loongson_llsc_mb();
do { do {
__asm__ __volatile__( __asm__ __volatile__(
...@@ -390,7 +386,6 @@ static inline int test_and_clear_bit(unsigned long nr, ...@@ -390,7 +386,6 @@ static inline int test_and_clear_bit(unsigned long nr,
: "ir" (bit) : "ir" (bit)
: __LLSC_CLOBBER); : __LLSC_CLOBBER);
} while (unlikely(!temp)); } while (unlikely(!temp));
#endif
} else { } else {
loongson_llsc_mb(); loongson_llsc_mb();
do { do {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment