Commit 59cf9a1c authored by Cyril Bur's avatar Cyril Bur Committed by Michael Ellerman

powerpc/opal: Make __opal_async_{get, release}_token() static

There are no callers of both __opal_async_get_token() and
__opal_async_release_token().

This patch also removes the possibility of "emergency through
synchronous call to __opal_async_get_token()" as such it makes more
sense to initialise opal_sync_sem for the maximum number of async
tokens.
Signed-off-by: default avatarCyril Bur <cyrilbur@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent efe69414
...@@ -306,9 +306,7 @@ extern void opal_notifier_enable(void); ...@@ -306,9 +306,7 @@ extern void opal_notifier_enable(void);
extern void opal_notifier_disable(void); extern void opal_notifier_disable(void);
extern void opal_notifier_update_evt(uint64_t evt_mask, uint64_t evt_val); extern void opal_notifier_update_evt(uint64_t evt_mask, uint64_t evt_val);
extern int __opal_async_get_token(void);
extern int opal_async_get_token_interruptible(void); extern int opal_async_get_token_interruptible(void);
extern int __opal_async_release_token(int token);
extern int opal_async_release_token(int token); extern int opal_async_release_token(int token);
extern int opal_async_wait_response(uint64_t token, struct opal_msg *msg); extern int opal_async_wait_response(uint64_t token, struct opal_msg *msg);
extern int opal_get_sensor_data(u32 sensor_hndl, u32 *sensor_data); extern int opal_get_sensor_data(u32 sensor_hndl, u32 *sensor_data);
......
...@@ -33,7 +33,7 @@ static struct semaphore opal_async_sem; ...@@ -33,7 +33,7 @@ static struct semaphore opal_async_sem;
static struct opal_msg *opal_async_responses; static struct opal_msg *opal_async_responses;
static unsigned int opal_max_async_tokens; static unsigned int opal_max_async_tokens;
int __opal_async_get_token(void) static int __opal_async_get_token(void)
{ {
unsigned long flags; unsigned long flags;
int token; int token;
...@@ -73,7 +73,7 @@ int opal_async_get_token_interruptible(void) ...@@ -73,7 +73,7 @@ int opal_async_get_token_interruptible(void)
} }
EXPORT_SYMBOL_GPL(opal_async_get_token_interruptible); EXPORT_SYMBOL_GPL(opal_async_get_token_interruptible);
int __opal_async_release_token(int token) static int __opal_async_release_token(int token)
{ {
unsigned long flags; unsigned long flags;
...@@ -199,11 +199,7 @@ int __init opal_async_comp_init(void) ...@@ -199,11 +199,7 @@ int __init opal_async_comp_init(void)
goto out_opal_node; goto out_opal_node;
} }
/* Initialize to 1 less than the maximum tokens available, as we may sema_init(&opal_async_sem, opal_max_async_tokens);
* require to pop one during emergency through synchronous call to
* __opal_async_get_token()
*/
sema_init(&opal_async_sem, opal_max_async_tokens - 1);
out_opal_node: out_opal_node:
of_node_put(opal_node); of_node_put(opal_node);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment