Commit 5bdbeb21 authored by Josef Bacik's avatar Josef Bacik

Btrfs: fix return code in drop_objectid_items

So dpkg fsync()'s the file and the directory containing the file whenever it
writes to a file which is really slow in btrfs.  This is partly because
fsync()'ing a directory _always_ committed the transaction instead of just
going to the tree log.  This is because drop_objectid_items() would return 1
since it does a btrfs_search_slot() which returns 1.  In tree-log jargon
this means that we have to commit the transaction to be safe.  So just check
if ret is greater than 0 and set it to 0 if it does.  With this patch we now
use the tree-log instead of committing the entire transaction, which is
twice as fast on my box.  Thanks,
Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
parent 22ee6985
...@@ -2667,6 +2667,8 @@ static int drop_objectid_items(struct btrfs_trans_handle *trans, ...@@ -2667,6 +2667,8 @@ static int drop_objectid_items(struct btrfs_trans_handle *trans,
btrfs_release_path(path); btrfs_release_path(path);
} }
btrfs_release_path(path); btrfs_release_path(path);
if (ret > 0)
ret = 0;
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment