Commit 5c2f37dd authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Greg Kroah-Hartman

serial: make FSL errata depend on 8250_CONSOLE, not just 8250

The recent commit "serial: add irq handler for Freescale 16550 errata"
would allow Kconfig choices that had 8250 support as a module and
yet still try and build in the errata fix non-modular, resulting
in build failures for some non-embedded PPC targets.

Since we hook in the errata fix from legacy_serial.c, which is
built only for PPC_UDBG_16550, and since the errata is only really
relevant for SysRQ on serial console, tighten up the dependencies
to be exactly that.

We'll get coverage on the relevant Freescale boards because the
Kconfig for their CPU types all select the PPC_UDBG_16550 option,
and the defconfigs also all select the 8250_CONSOLE option.  Also,
the 8250_CONSOLE option has a strict dependency on "SERIAL_8250=y"
which resolves the reported problem for non Freescale targets.
Reported-by: default avatarMichael Neuling <mikey@neuling.org>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Tested-by: default avatarMichael Neuling <mikey@neuling.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 9deaa53a
...@@ -99,7 +99,7 @@ config SERIAL_8250_PNP ...@@ -99,7 +99,7 @@ config SERIAL_8250_PNP
config SERIAL_8250_FSL config SERIAL_8250_FSL
bool bool
depends on SERIAL_8250 && PPC depends on SERIAL_8250_CONSOLE && PPC_UDBG_16550
default PPC default PPC
config SERIAL_8250_HP300 config SERIAL_8250_HP300
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment