Commit 5f65e5ca authored by Seth Forshee's avatar Seth Forshee Committed by Eric W. Biederman

cred: Reject inodes with invalid ids in set_create_file_as()

Using INVALID_[UG]ID for the LSM file creation context doesn't
make sense, so return an error if the inode passed to
set_create_file_as() has an invalid id.
Signed-off-by: default avatarSeth Forshee <seth.forshee@canonical.com>
Acked-by: default avatarSerge Hallyn <serge.hallyn@canonical.com>
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
parent 2d7f9e2a
...@@ -689,6 +689,8 @@ EXPORT_SYMBOL(set_security_override_from_ctx); ...@@ -689,6 +689,8 @@ EXPORT_SYMBOL(set_security_override_from_ctx);
*/ */
int set_create_files_as(struct cred *new, struct inode *inode) int set_create_files_as(struct cred *new, struct inode *inode)
{ {
if (!uid_valid(inode->i_uid) || !gid_valid(inode->i_gid))
return -EINVAL;
new->fsuid = inode->i_uid; new->fsuid = inode->i_uid;
new->fsgid = inode->i_gid; new->fsgid = inode->i_gid;
return security_kernel_create_files_as(new, inode); return security_kernel_create_files_as(new, inode);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment