Commit 6367da46 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe

RDMA/mlx5: Remove redundant destroy QP call

After major refactoring in create QP flow, it is no needed to call
to destroy QP in XRC_TGT flow.

Link: https://lore.kernel.org/r/20200427154636.381474-35-leon@kernel.orgReviewed-by: default avatarMaor Gottlieb <maorg@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 08d53976
...@@ -1887,7 +1887,6 @@ static int create_xrc_tgt_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp, ...@@ -1887,7 +1887,6 @@ static int create_xrc_tgt_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
struct mlx5_create_qp_params *params) struct mlx5_create_qp_params *params)
{ {
struct ib_qp_init_attr *attr = params->attr; struct ib_qp_init_attr *attr = params->attr;
struct ib_udata *udata = params->udata;
u32 uidx = params->uidx; u32 uidx = params->uidx;
struct mlx5_ib_resources *devr = &dev->devr; struct mlx5_ib_resources *devr = &dev->devr;
int inlen = MLX5_ST_SZ_BYTES(create_qp_in); int inlen = MLX5_ST_SZ_BYTES(create_qp_in);
...@@ -1944,10 +1943,8 @@ static int create_xrc_tgt_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp, ...@@ -1944,10 +1943,8 @@ static int create_xrc_tgt_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
base = &qp->trans_qp.base; base = &qp->trans_qp.base;
err = mlx5_core_create_qp(dev, &base->mqp, in, inlen); err = mlx5_core_create_qp(dev, &base->mqp, in, inlen);
kvfree(in); kvfree(in);
if (err) { if (err)
destroy_qp(dev, qp, base, udata);
return err; return err;
}
base->container_mibqp = qp; base->container_mibqp = qp;
base->mqp.event = mlx5_ib_qp_event; base->mqp.event = mlx5_ib_qp_event;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment