Commit 6512f5fb authored by Julia Lawall's avatar Julia Lawall Committed by Laurent Pinchart

drm: rcar-du: fix error return code

Propagate the error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
parent a218df07
...@@ -586,7 +586,7 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index) ...@@ -586,7 +586,7 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index)
if (irq < 0) { if (irq < 0) {
dev_err(rcdu->dev, "no IRQ for CRTC %u\n", index); dev_err(rcdu->dev, "no IRQ for CRTC %u\n", index);
return ret; return irq;
} }
ret = devm_request_irq(rcdu->dev, irq, rcar_du_crtc_irq, irqflags, ret = devm_request_irq(rcdu->dev, irq, rcar_du_crtc_irq, irqflags,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment