Commit 655745b0 authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Greg Kroah-Hartman

VMCI: use memdup_user().

Use memdup_user to duplicate a memory region from user-space to
kernel-space, instead of open coding using kmalloc & copy_from_user.
Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b58189b3
...@@ -381,18 +381,12 @@ static int vmci_host_do_send_datagram(struct vmci_host_dev *vmci_host_dev, ...@@ -381,18 +381,12 @@ static int vmci_host_do_send_datagram(struct vmci_host_dev *vmci_host_dev,
return -EINVAL; return -EINVAL;
} }
dg = kmalloc(send_info.len, GFP_KERNEL); dg = memdup_user((void __user *)(uintptr_t)send_info.addr,
if (!dg) { send_info.len);
if (IS_ERR(dg)) {
vmci_ioctl_err( vmci_ioctl_err(
"cannot allocate memory to dispatch datagram\n"); "cannot allocate memory to dispatch datagram\n");
return -ENOMEM; return PTR_ERR(dg);
}
if (copy_from_user(dg, (void __user *)(uintptr_t)send_info.addr,
send_info.len)) {
vmci_ioctl_err("error getting datagram\n");
kfree(dg);
return -EFAULT;
} }
if (VMCI_DG_SIZE(dg) != send_info.len) { if (VMCI_DG_SIZE(dg) != send_info.len) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment