Commit 66a85155 authored by James Smart's avatar James Smart Committed by Martin K. Petersen

scsi: lpfc: Fix NULL pointer reference when resetting adapter

Points referencing local port structures didn't accommodate cases where
the localport may not be registered yet.

Add NULL pointer checks to logic.
Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent b15bd3e6
...@@ -364,16 +364,18 @@ lpfc_nvme_cmpl_gen_req(struct lpfc_hba *phba, struct lpfc_iocbq *cmdwqe, ...@@ -364,16 +364,18 @@ lpfc_nvme_cmpl_gen_req(struct lpfc_hba *phba, struct lpfc_iocbq *cmdwqe,
struct lpfc_dmabuf *buf_ptr; struct lpfc_dmabuf *buf_ptr;
struct lpfc_nodelist *ndlp; struct lpfc_nodelist *ndlp;
lport = (struct lpfc_nvme_lport *)vport->localport->private;
pnvme_lsreq = (struct nvmefc_ls_req *)cmdwqe->context2; pnvme_lsreq = (struct nvmefc_ls_req *)cmdwqe->context2;
status = bf_get(lpfc_wcqe_c_status, wcqe) & LPFC_IOCB_STATUS_MASK; status = bf_get(lpfc_wcqe_c_status, wcqe) & LPFC_IOCB_STATUS_MASK;
if (lport) { if (vport->localport) {
atomic_inc(&lport->fc4NvmeLsCmpls); lport = (struct lpfc_nvme_lport *)vport->localport->private;
if (status) { if (lport) {
if (bf_get(lpfc_wcqe_c_xb, wcqe)) atomic_inc(&lport->fc4NvmeLsCmpls);
atomic_inc(&lport->cmpl_ls_xb); if (status) {
atomic_inc(&lport->cmpl_ls_err); if (bf_get(lpfc_wcqe_c_xb, wcqe))
atomic_inc(&lport->cmpl_ls_xb);
atomic_inc(&lport->cmpl_ls_err);
}
} }
} }
...@@ -980,15 +982,17 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn, ...@@ -980,15 +982,17 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
rport = lpfc_ncmd->nrport; rport = lpfc_ncmd->nrport;
status = bf_get(lpfc_wcqe_c_status, wcqe); status = bf_get(lpfc_wcqe_c_status, wcqe);
lport = (struct lpfc_nvme_lport *)vport->localport->private; if (vport->localport) {
if (lport) { lport = (struct lpfc_nvme_lport *)vport->localport->private;
idx = lpfc_ncmd->cur_iocbq.hba_wqidx; if (lport) {
cstat = &lport->cstat[idx]; idx = lpfc_ncmd->cur_iocbq.hba_wqidx;
atomic_inc(&cstat->fc4NvmeIoCmpls); cstat = &lport->cstat[idx];
if (status) { atomic_inc(&cstat->fc4NvmeIoCmpls);
if (bf_get(lpfc_wcqe_c_xb, wcqe)) if (status) {
atomic_inc(&lport->cmpl_fcp_xb); if (bf_get(lpfc_wcqe_c_xb, wcqe))
atomic_inc(&lport->cmpl_fcp_err); atomic_inc(&lport->cmpl_fcp_xb);
atomic_inc(&lport->cmpl_fcp_err);
}
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment