Commit 66ec4bfc authored by Amit Kucheria's avatar Amit Kucheria Committed by Daniel Lezcano

thermal: rockchip: Appease the kernel-doc deity

Replace a comment starting with /** by simply /* to avoid having it
interpreted as a kernel-doc comment. Describe missing function
parameters where needed.

Fixes up the following warnings when compiled with make W=1:

linux.git/drivers/thermal/rockchip_thermal.c:27: warning: cannot
understand function prototype: 'enum tshut_mode '
linux.git/drivers/thermal/rockchip_thermal.c:37: warning: cannot
understand function prototype: 'enum tshut_polarity '
linux.git/drivers/thermal/rockchip_thermal.c:46: warning: cannot
understand function prototype: 'enum sensor_id '
linux.git/drivers/thermal/rockchip_thermal.c:56: warning: cannot
understand function prototype: 'enum adc_sort_mode '
linux.git/drivers/thermal/rockchip_thermal.c:123: warning: Function
parameter or member 'chn_id' not described in 'rockchip_tsadc_chip'
linux.git/drivers/thermal/rockchip_thermal.c:123: warning: Function
parameter or member 'control' not described in 'rockchip_tsadc_chip'
linux.git/drivers/thermal/rockchip_thermal.c:167: warning: Function
parameter or member 'sensors' not described in 'rockchip_thermal_data'
linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function
parameter or member 'grf' not described in 'rk_tsadcv2_initialize'
linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function
parameter or member 'regs' not described in 'rk_tsadcv2_initialize'
linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function
parameter or member 'tshut_polarity' not described in
'rk_tsadcv2_initialize'
linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function
parameter or member 'grf' not described in 'rk_tsadcv3_initialize'
linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function
parameter or member 'regs' not described in 'rk_tsadcv3_initialize'
linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function
parameter or member 'tshut_polarity' not described in
'rk_tsadcv3_initialize'
linux.git/drivers/thermal/rockchip_thermal.c:732: warning: Function
parameter or member 'regs' not described in 'rk_tsadcv3_control'
linux.git/drivers/thermal/rockchip_thermal.c:732: warning: Function
parameter or member 'enable' not described in 'rk_tsadcv3_control'
linux.git/drivers/thermal/rockchip_thermal.c:1211: warning: Function
parameter or member 'reset' not described in
'rockchip_thermal_reset_controller'
Signed-off-by: default avatarAmit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/c3cbdb0619fec602668ba7ae703ba49d67e30b33.1574242756.git.amit.kucheria@linaro.org
parent 3772bb42
...@@ -19,7 +19,7 @@ ...@@ -19,7 +19,7 @@
#include <linux/mfd/syscon.h> #include <linux/mfd/syscon.h>
#include <linux/pinctrl/consumer.h> #include <linux/pinctrl/consumer.h>
/** /*
* If the temperature over a period of time High, * If the temperature over a period of time High,
* the resulting TSHUT gave CRU module,let it reset the entire chip, * the resulting TSHUT gave CRU module,let it reset the entire chip,
* or via GPIO give PMIC. * or via GPIO give PMIC.
...@@ -29,7 +29,7 @@ enum tshut_mode { ...@@ -29,7 +29,7 @@ enum tshut_mode {
TSHUT_MODE_GPIO, TSHUT_MODE_GPIO,
}; };
/** /*
* The system Temperature Sensors tshut(tshut) polarity * The system Temperature Sensors tshut(tshut) polarity
* the bit 8 is tshut polarity. * the bit 8 is tshut polarity.
* 0: low active, 1: high active * 0: low active, 1: high active
...@@ -39,7 +39,7 @@ enum tshut_polarity { ...@@ -39,7 +39,7 @@ enum tshut_polarity {
TSHUT_HIGH_ACTIVE, TSHUT_HIGH_ACTIVE,
}; };
/** /*
* The system has two Temperature Sensors. * The system has two Temperature Sensors.
* sensor0 is for CPU, and sensor1 is for GPU. * sensor0 is for CPU, and sensor1 is for GPU.
*/ */
...@@ -48,7 +48,7 @@ enum sensor_id { ...@@ -48,7 +48,7 @@ enum sensor_id {
SENSOR_GPU, SENSOR_GPU,
}; };
/** /*
* The conversion table has the adc value and temperature. * The conversion table has the adc value and temperature.
* ADC_DECREMENT: the adc value is of diminishing.(e.g. rk3288_code_table) * ADC_DECREMENT: the adc value is of diminishing.(e.g. rk3288_code_table)
* ADC_INCREMENT: the adc value is incremental.(e.g. rk3368_code_table) * ADC_INCREMENT: the adc value is incremental.(e.g. rk3368_code_table)
...@@ -80,13 +80,14 @@ struct chip_tsadc_table { ...@@ -80,13 +80,14 @@ struct chip_tsadc_table {
/** /**
* struct rockchip_tsadc_chip - hold the private data of tsadc chip * struct rockchip_tsadc_chip - hold the private data of tsadc chip
* @chn_id[SOC_MAX_SENSORS]: the sensor id of chip correspond to the channel * @chn_id: array of sensor ids of chip corresponding to the channel
* @chn_num: the channel number of tsadc chip * @chn_num: the channel number of tsadc chip
* @tshut_temp: the hardware-controlled shutdown temperature value * @tshut_temp: the hardware-controlled shutdown temperature value
* @tshut_mode: the hardware-controlled shutdown mode (0:CRU 1:GPIO) * @tshut_mode: the hardware-controlled shutdown mode (0:CRU 1:GPIO)
* @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH) * @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH)
* @initialize: SoC special initialize tsadc controller method * @initialize: SoC special initialize tsadc controller method
* @irq_ack: clear the interrupt * @irq_ack: clear the interrupt
* @control: enable/disable method for the tsadc controller
* @get_temp: get the temperature * @get_temp: get the temperature
* @set_alarm_temp: set the high temperature interrupt * @set_alarm_temp: set the high temperature interrupt
* @set_tshut_temp: set the hardware-controlled shutdown temperature * @set_tshut_temp: set the hardware-controlled shutdown temperature
...@@ -139,7 +140,7 @@ struct rockchip_thermal_sensor { ...@@ -139,7 +140,7 @@ struct rockchip_thermal_sensor {
* @chip: pointer to the platform/configuration data * @chip: pointer to the platform/configuration data
* @pdev: platform device of thermal * @pdev: platform device of thermal
* @reset: the reset controller of tsadc * @reset: the reset controller of tsadc
* @sensors[SOC_MAX_SENSORS]: the thermal sensor * @sensors: array of thermal sensors
* @clk: the controller clock is divided by the exteral 24MHz * @clk: the controller clock is divided by the exteral 24MHz
* @pclk: the advanced peripherals bus clock * @pclk: the advanced peripherals bus clock
* @grf: the general register file will be used to do static set by software * @grf: the general register file will be used to do static set by software
...@@ -590,6 +591,9 @@ static int rk_tsadcv2_code_to_temp(const struct chip_tsadc_table *table, ...@@ -590,6 +591,9 @@ static int rk_tsadcv2_code_to_temp(const struct chip_tsadc_table *table,
/** /**
* rk_tsadcv2_initialize - initialize TASDC Controller. * rk_tsadcv2_initialize - initialize TASDC Controller.
* @grf: the general register file will be used to do static set by software
* @regs: the base address of tsadc controller
* @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH)
* *
* (1) Set TSADC_V2_AUTO_PERIOD: * (1) Set TSADC_V2_AUTO_PERIOD:
* Configure the interleave between every two accessing of * Configure the interleave between every two accessing of
...@@ -624,6 +628,9 @@ static void rk_tsadcv2_initialize(struct regmap *grf, void __iomem *regs, ...@@ -624,6 +628,9 @@ static void rk_tsadcv2_initialize(struct regmap *grf, void __iomem *regs,
/** /**
* rk_tsadcv3_initialize - initialize TASDC Controller. * rk_tsadcv3_initialize - initialize TASDC Controller.
* @grf: the general register file will be used to do static set by software
* @regs: the base address of tsadc controller
* @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH)
* *
* (1) The tsadc control power sequence. * (1) The tsadc control power sequence.
* *
...@@ -723,6 +730,8 @@ static void rk_tsadcv2_control(void __iomem *regs, bool enable) ...@@ -723,6 +730,8 @@ static void rk_tsadcv2_control(void __iomem *regs, bool enable)
/** /**
* rk_tsadcv3_control - the tsadc controller is enabled or disabled. * rk_tsadcv3_control - the tsadc controller is enabled or disabled.
* @regs: the base address of tsadc controller
* @enable: boolean flag to enable the controller
* *
* NOTE: TSADC controller works at auto mode, and some SoCs need set the * NOTE: TSADC controller works at auto mode, and some SoCs need set the
* tsadc_q_sel bit on TSADCV2_AUTO_CON[1]. The (1024 - tsadc_q) as output * tsadc_q_sel bit on TSADCV2_AUTO_CON[1]. The (1024 - tsadc_q) as output
...@@ -1206,6 +1215,7 @@ rockchip_thermal_register_sensor(struct platform_device *pdev, ...@@ -1206,6 +1215,7 @@ rockchip_thermal_register_sensor(struct platform_device *pdev,
/** /**
* Reset TSADC Controller, reset all tsadc registers. * Reset TSADC Controller, reset all tsadc registers.
* @reset: the reset controller of tsadc
*/ */
static void rockchip_thermal_reset_controller(struct reset_control *reset) static void rockchip_thermal_reset_controller(struct reset_control *reset)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment