Commit 66f8a8ff authored by Jean Delvare's avatar Jean Delvare Committed by Wolfram Sang

i2c: piix4: Standardize log messages

Use exactly the same log messages in the legacy setup function and the
SB800+ setup function. This way strings can be reused, which saves
some bytes in the generated binary.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 85fd0fe6
...@@ -208,16 +208,16 @@ static int piix4_setup(struct pci_dev *PIIX4_dev, ...@@ -208,16 +208,16 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
"WARNING: SMBus interface has been FORCEFULLY ENABLED!\n"); "WARNING: SMBus interface has been FORCEFULLY ENABLED!\n");
} else { } else {
dev_err(&PIIX4_dev->dev, dev_err(&PIIX4_dev->dev,
"Host SMBus controller not enabled!\n"); "SMBus Host Controller not enabled!\n");
release_region(piix4_smba, SMBIOSIZE); release_region(piix4_smba, SMBIOSIZE);
return -ENODEV; return -ENODEV;
} }
} }
if (((temp & 0x0E) == 8) || ((temp & 0x0E) == 2)) if (((temp & 0x0E) == 8) || ((temp & 0x0E) == 2))
dev_dbg(&PIIX4_dev->dev, "Using Interrupt 9 for SMBus.\n"); dev_dbg(&PIIX4_dev->dev, "Using IRQ for SMBus\n");
else if ((temp & 0x0E) == 0) else if ((temp & 0x0E) == 0)
dev_dbg(&PIIX4_dev->dev, "Using Interrupt SMI# for SMBus.\n"); dev_dbg(&PIIX4_dev->dev, "Using SMI# for SMBus\n");
else else
dev_err(&PIIX4_dev->dev, "Illegal Interrupt configuration " dev_err(&PIIX4_dev->dev, "Illegal Interrupt configuration "
"(or code out of date)!\n"); "(or code out of date)!\n");
...@@ -279,7 +279,7 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev, ...@@ -279,7 +279,7 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
if (!smb_en_status) { if (!smb_en_status) {
dev_err(&PIIX4_dev->dev, dev_err(&PIIX4_dev->dev,
"Host SMBus controller not enabled!\n"); "SMBus Host Controller not enabled!\n");
return -ENODEV; return -ENODEV;
} }
...@@ -311,9 +311,9 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev, ...@@ -311,9 +311,9 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
release_region(piix4_smba + i2ccfg_offset, 1); release_region(piix4_smba + i2ccfg_offset, 1);
if (i2ccfg & 1) if (i2ccfg & 1)
dev_dbg(&PIIX4_dev->dev, "Using IRQ for SMBus.\n"); dev_dbg(&PIIX4_dev->dev, "Using IRQ for SMBus\n");
else else
dev_dbg(&PIIX4_dev->dev, "Using SMI# for SMBus.\n"); dev_dbg(&PIIX4_dev->dev, "Using SMI# for SMBus\n");
dev_info(&PIIX4_dev->dev, dev_info(&PIIX4_dev->dev,
"SMBus Host Controller at 0x%x, revision %d\n", "SMBus Host Controller at 0x%x, revision %d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment