Commit 672bfdaa authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Felipe Balbi

usb: renesas_usbhs: avoid uninitialized variable use

After the renesas_usbhs driver is enabled in ARM multi_v7_defconfig,
we now get a new warning:

renesas_usbhs/mod.c: In function 'usbhs_interrupt':
renesas_usbhs/mod.c:246:7: warning: 'intenb1' may be used uninitialized in this function [-Wmaybe-uninitialized]

gcc correctly points to a problem here, for the case that the
device is in host mode, we use the intenb1 variable without
having assigned it first. The state->intsts1 has a similar
problem, but gcc cannot know that.

This avoids the problem by initializing both sides of the
comparison to zero when we don't read them from the respective
registers.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: 88a25e02 ("usb: renesas_usbhs: Add access control for INTSTS1 and INTENB1 register")
Acked-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 81dff869
...@@ -223,6 +223,8 @@ static int usbhs_status_get_each_irq(struct usbhs_priv *priv, ...@@ -223,6 +223,8 @@ static int usbhs_status_get_each_irq(struct usbhs_priv *priv,
if (usbhs_mod_is_host(priv)) { if (usbhs_mod_is_host(priv)) {
state->intsts1 = usbhs_read(priv, INTSTS1); state->intsts1 = usbhs_read(priv, INTSTS1);
intenb1 = usbhs_read(priv, INTENB1); intenb1 = usbhs_read(priv, INTENB1);
} else {
state->intsts1 = intenb1 = 0;
} }
/* mask */ /* mask */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment