Commit 697dae1e authored by yuval.shaia@oracle.com's avatar yuval.shaia@oracle.com Committed by David S. Miller

net/3com: Make el3_netdev_get_ecmd return void

Make return value void since function never returns meaningfull value.
Signed-off-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 82c01a84
...@@ -1039,7 +1039,7 @@ el3_link_ok(struct net_device *dev) ...@@ -1039,7 +1039,7 @@ el3_link_ok(struct net_device *dev)
return tmp & (1<<11); return tmp & (1<<11);
} }
static int static void
el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd) el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
{ {
u16 tmp; u16 tmp;
...@@ -1082,7 +1082,6 @@ el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd) ...@@ -1082,7 +1082,6 @@ el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
supported); supported);
cmd->base.speed = SPEED_10; cmd->base.speed = SPEED_10;
EL3WINDOW(1); EL3WINDOW(1);
return 0;
} }
static int static int
...@@ -1151,12 +1150,11 @@ static int el3_get_link_ksettings(struct net_device *dev, ...@@ -1151,12 +1150,11 @@ static int el3_get_link_ksettings(struct net_device *dev,
struct ethtool_link_ksettings *cmd) struct ethtool_link_ksettings *cmd)
{ {
struct el3_private *lp = netdev_priv(dev); struct el3_private *lp = netdev_priv(dev);
int ret;
spin_lock_irq(&lp->lock); spin_lock_irq(&lp->lock);
ret = el3_netdev_get_ecmd(dev, cmd); el3_netdev_get_ecmd(dev, cmd);
spin_unlock_irq(&lp->lock); spin_unlock_irq(&lp->lock);
return ret; return 0;
} }
static int el3_set_link_ksettings(struct net_device *dev, static int el3_set_link_ksettings(struct net_device *dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment