Commit 6b4e81db authored by Jim Bos's avatar Jim Bos Committed by Linus Torvalds

i8k: Tell gcc that *regs gets clobbered

More recent GCC caused the i8k driver to stop working, on Slackware
compiler was upgraded from gcc-4.4.4 to gcc-4.5.1 after which it didn't
work anymore, meaning the driver didn't load or gave total nonsensical
output.

As it turned out the asm(..) statement forgot to mention it modifies the
*regs variable.

Credits to Andi Kleen and Andreas Schwab for providing the fix.
Signed-off-by: default avatarJim Bos <jim876@xs4all.nl>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ed3aada1
...@@ -142,7 +142,7 @@ static int i8k_smm(struct smm_regs *regs) ...@@ -142,7 +142,7 @@ static int i8k_smm(struct smm_regs *regs)
"lahf\n\t" "lahf\n\t"
"shrl $8,%%eax\n\t" "shrl $8,%%eax\n\t"
"andl $1,%%eax\n" "andl $1,%%eax\n"
:"=a"(rc) :"=a"(rc), "+m" (*regs)
: "a"(regs) : "a"(regs)
: "%ebx", "%ecx", "%edx", "%esi", "%edi", "memory"); : "%ebx", "%ecx", "%edx", "%esi", "%edi", "memory");
#else #else
...@@ -167,7 +167,8 @@ static int i8k_smm(struct smm_regs *regs) ...@@ -167,7 +167,8 @@ static int i8k_smm(struct smm_regs *regs)
"movl %%edx,0(%%eax)\n\t" "movl %%edx,0(%%eax)\n\t"
"lahf\n\t" "lahf\n\t"
"shrl $8,%%eax\n\t" "shrl $8,%%eax\n\t"
"andl $1,%%eax\n":"=a"(rc) "andl $1,%%eax\n"
:"=a"(rc), "+m" (*regs)
: "a"(regs) : "a"(regs)
: "%ebx", "%ecx", "%edx", "%esi", "%edi", "memory"); : "%ebx", "%ecx", "%edx", "%esi", "%edi", "memory");
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment