Commit 6ea6b7fa authored by Linus Walleij's avatar Linus Walleij Committed by Ralf Baechle

MIPS: TXx9: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Cc: linux-mips@linux-mips.org
Cc: linux-gpio@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/11923/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 249e573d
...@@ -21,7 +21,7 @@ static struct txx9_pio_reg __iomem *txx9_pioptr; ...@@ -21,7 +21,7 @@ static struct txx9_pio_reg __iomem *txx9_pioptr;
static int txx9_gpio_get(struct gpio_chip *chip, unsigned int offset) static int txx9_gpio_get(struct gpio_chip *chip, unsigned int offset)
{ {
return __raw_readl(&txx9_pioptr->din) & (1 << offset); return !!(__raw_readl(&txx9_pioptr->din) & (1 << offset));
} }
static void txx9_gpio_set_raw(unsigned int offset, int value) static void txx9_gpio_set_raw(unsigned int offset, int value)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment