Commit 705cbbbe authored by Alexander Aring's avatar Alexander Aring Committed by Marcel Holtmann

mac802154: cleanup ieee802154_netdev_to_extended_addr

This patch cleanups the ieee802154_be64_to_le64 to have a similar
function like ieee802154_le64_to_be64 only with switched source and
destionation types.
Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 239a84a9
...@@ -224,12 +224,15 @@ struct ieee802154_ops { ...@@ -224,12 +224,15 @@ struct ieee802154_ops {
}; };
/** /**
* ieee802154_netdev_to_extended_addr - convert big endian 64 byte void pointer to __le64 * ieee802154_be64_to_le64 - copies and convert be64 to le64
* @dev_addr: big endian address pointer like netdevice dev_addr attribute * @le64_dst: le64 destination pointer
* @be64_src: be64 source pointer
*/ */
static inline __le64 ieee802154_netdev_to_extended_addr(const void *dev_addr) static inline void ieee802154_be64_to_le64(void *le64_dst, const void *be64_src)
{ {
return (__force __le64)swab64p(dev_addr); __le64 tmp = (__force __le64)swab64p(be64_src);
memcpy(le64_dst, &tmp, IEEE802154_EXTENDED_ADDR_LEN);
} }
/** /**
......
...@@ -117,7 +117,7 @@ static int mac802154_wpan_mac_addr(struct net_device *dev, void *p) ...@@ -117,7 +117,7 @@ static int mac802154_wpan_mac_addr(struct net_device *dev, void *p)
if (netif_running(dev)) if (netif_running(dev))
return -EBUSY; return -EBUSY;
extended_addr = ieee802154_netdev_to_extended_addr(addr->sa_data); ieee802154_be64_to_le64(&extended_addr, addr->sa_data);
if (!ieee802154_is_valid_extended_addr(extended_addr)) if (!ieee802154_is_valid_extended_addr(extended_addr))
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment