Commit 7210c678 authored by Kyle McMartin's avatar Kyle McMartin

[PARISC] fix uninitialized variable warning in asm/rtc.h

get_rtc_time, in the case that PDC returns that the battery is bad, returns
an unmodified rtc_time arg to the caller, which then uses uninitialized
values. Fix this by memset-ing the arg with zeroes, so it will at least be
cleared if we return failure.

Spotted by John David Anglin.
Signed-off-by: default avatarKyle McMartin <kyle@mcmartin.ca>
parent 562d139c
...@@ -50,10 +50,10 @@ static inline unsigned int get_rtc_time(struct rtc_time *wtime) ...@@ -50,10 +50,10 @@ static inline unsigned int get_rtc_time(struct rtc_time *wtime)
long int days, rem, y; long int days, rem, y;
const unsigned short int *ip; const unsigned short int *ip;
if(pdc_tod_read(&tod_data) < 0) memset(wtime, 0, sizeof(*wtime));
if (pdc_tod_read(&tod_data) < 0)
return RTC_24H | RTC_BATT_BAD; return RTC_24H | RTC_BATT_BAD;
// most of the remainder of this function is: // most of the remainder of this function is:
// Copyright (C) 1991, 1993, 1997, 1998 Free Software Foundation, Inc. // Copyright (C) 1991, 1993, 1997, 1998 Free Software Foundation, Inc.
// This was originally a part of the GNU C Library. // This was originally a part of the GNU C Library.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment