Commit 724dfc25 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

Staging: gdm72xx: silence underflow warning in netlink_send()

The value of "group" comes from "idx" in __gdm_wimax_event_send():

	if (sscanf(e->dev->name, "wm%d", &idx) == 1)

Smatch marks sscanf values as user controlled.  It's supposed to be a
number in 0-30 range.  We cap the upper bound but allow negatives.  Fix
this by making it type u16 instead.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c688671d
...@@ -114,7 +114,7 @@ void netlink_exit(struct sock *sock) ...@@ -114,7 +114,7 @@ void netlink_exit(struct sock *sock)
netlink_kernel_release(sock); netlink_kernel_release(sock);
} }
int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len) int netlink_send(struct sock *sock, u16 group, u16 type, void *msg, int len)
{ {
static u32 seq; static u32 seq;
struct sk_buff *skb = NULL; struct sk_buff *skb = NULL;
......
...@@ -20,6 +20,6 @@ ...@@ -20,6 +20,6 @@
struct sock *netlink_init(int unit, void (*cb)(struct net_device *dev, u16 type, struct sock *netlink_init(int unit, void (*cb)(struct net_device *dev, u16 type,
void *msg, int len)); void *msg, int len));
void netlink_exit(struct sock *sock); void netlink_exit(struct sock *sock);
int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len); int netlink_send(struct sock *sock, u16 group, u16 type, void *msg, int len);
#endif /* __GDM72XX_NETLINK_K_H__ */ #endif /* __GDM72XX_NETLINK_K_H__ */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment