Commit 72ebddb5 authored by David Brownell's avatar David Brownell Committed by Greg Kroah-Hartman

[PATCH] USB: turn a user mode driver error into a hard error

This patch turns a user mode driver error into a hard error, and updates
the relevant diagnostic slightly to help troubleshooting.  gphoto was
known to have this problem, hopefully it is now fixed (they have had
plenty of warning...)

This had been left as a soft error to give various user mode drivers a
change to be properly fixed, with the statement that starting in about
2.6.10 it would be changed.  It had been mostly safe as a soft error ...
but that can not be guaranteed.  Now that a year has passed, it's time to
really insist that the user mode drivers finally fix their relevant bugs.
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 589a0083
...@@ -784,16 +784,16 @@ static int proc_setconfig(struct dev_state *ps, void __user *arg) ...@@ -784,16 +784,16 @@ static int proc_setconfig(struct dev_state *ps, void __user *arg)
for (i = 0; i < actconfig->desc.bNumInterfaces; ++i) { for (i = 0; i < actconfig->desc.bNumInterfaces; ++i) {
if (usb_interface_claimed(actconfig->interface[i])) { if (usb_interface_claimed(actconfig->interface[i])) {
dev_warn (&ps->dev->dev, dev_warn (&ps->dev->dev,
"usbfs: interface %d claimed " "usbfs: interface %d claimed by %s "
"while '%s' sets config #%d\n", "while '%s' sets config #%d\n",
actconfig->interface[i] actconfig->interface[i]
->cur_altsetting ->cur_altsetting
->desc.bInterfaceNumber, ->desc.bInterfaceNumber,
actconfig->interface[i]
->dev.driver->name,
current->comm, u); current->comm, u);
#if 0 /* FIXME: enable in 2.6.10 or so */
status = -EBUSY; status = -EBUSY;
break; break;
#endif
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment