Commit 73a3ca20 authored by Hans van Kranenburg's avatar Hans van Kranenburg Committed by David Sterba

btrfs: clarify btrfs_ioctl_get_dev_stats padding

In commit c11d2c23 ("Btrfs: add ioctl to get and reset the device
stats") the get_dev_stats ioctl was added.

Shortly thereafter, in commit b27f7c0c ("btrfs: join DEV_STATS
ioctls to one") , the flags field was added.  However, the calculation
for unused padding space was not updated, which also invalidated the
comment.

Clarify what happened to reduce confusion and wasted time for anyone
implementing this.
Signed-off-by: default avatarHans van Kranenburg <hans.van.kranenburg@mendix.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 202f64ef
...@@ -665,7 +665,12 @@ struct btrfs_ioctl_get_dev_stats { ...@@ -665,7 +665,12 @@ struct btrfs_ioctl_get_dev_stats {
/* out values: */ /* out values: */
__u64 values[BTRFS_DEV_STAT_VALUES_MAX]; __u64 values[BTRFS_DEV_STAT_VALUES_MAX];
__u64 unused[128 - 2 - BTRFS_DEV_STAT_VALUES_MAX]; /* pad to 1k */ /*
* This pads the struct to 1032 bytes. It was originally meant to pad to
* 1024 bytes, but when adding the flags field, the padding calculation
* was not adjusted.
*/
__u64 unused[128 - 2 - BTRFS_DEV_STAT_VALUES_MAX];
}; };
#define BTRFS_QUOTA_CTL_ENABLE 1 #define BTRFS_QUOTA_CTL_ENABLE 1
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment