Commit 7435b32e authored by Michael Cyr's avatar Michael Cyr Committed by Martin K. Petersen

scsi: ibmvscsis: Clean up properly if target_submit_cmd/tmr fails

Signed-off-by: default avatarMichael Cyr <mikecyr@us.ibm.com>
Signed-off-by: default avatarBryant G. Ly <bryantly@linux.vnet.ibm.com>
Tested-by: default avatarSteven Royer <seroyer@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8bf11557
...@@ -2560,6 +2560,10 @@ static void ibmvscsis_parse_cmd(struct scsi_info *vscsi, ...@@ -2560,6 +2560,10 @@ static void ibmvscsis_parse_cmd(struct scsi_info *vscsi,
data_len, attr, dir, 0); data_len, attr, dir, 0);
if (rc) { if (rc) {
dev_err(&vscsi->dev, "target_submit_cmd failed, rc %d\n", rc); dev_err(&vscsi->dev, "target_submit_cmd failed, rc %d\n", rc);
spin_lock_bh(&vscsi->intr_lock);
list_del(&cmd->list);
ibmvscsis_free_cmd_resources(vscsi, cmd);
spin_unlock_bh(&vscsi->intr_lock);
goto fail; goto fail;
} }
return; return;
...@@ -2639,6 +2643,9 @@ static void ibmvscsis_parse_task(struct scsi_info *vscsi, ...@@ -2639,6 +2643,9 @@ static void ibmvscsis_parse_task(struct scsi_info *vscsi,
if (rc) { if (rc) {
dev_err(&vscsi->dev, "target_submit_tmr failed, rc %d\n", dev_err(&vscsi->dev, "target_submit_tmr failed, rc %d\n",
rc); rc);
spin_lock_bh(&vscsi->intr_lock);
list_del(&cmd->list);
spin_unlock_bh(&vscsi->intr_lock);
cmd->se_cmd.se_tmr_req->response = cmd->se_cmd.se_tmr_req->response =
TMR_FUNCTION_REJECTED; TMR_FUNCTION_REJECTED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment