Commit 74422e2b authored by Suraj Jitindar Singh's avatar Suraj Jitindar Singh Committed by Michael Ellerman

powerpc/pseries: Remove VLA from lparcfg_write()

In lparcfg_write we hard code kbuf_sz and then use this as the variable
length of kbuf creating a variable length array. Since we're hard coding
the length anyway just define the array using this as the length and
remove the need for kbuf_sz, thus removing the variable length array.
Signed-off-by: default avatarSuraj Jitindar Singh <sjitindarsingh@gmail.com>
Reviewed-by: default avatarJoel Stanley <joel@jms.id.au>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent ab912399
...@@ -585,8 +585,7 @@ static ssize_t update_mpp(u64 *entitlement, u8 *weight) ...@@ -585,8 +585,7 @@ static ssize_t update_mpp(u64 *entitlement, u8 *weight)
static ssize_t lparcfg_write(struct file *file, const char __user * buf, static ssize_t lparcfg_write(struct file *file, const char __user * buf,
size_t count, loff_t * off) size_t count, loff_t * off)
{ {
int kbuf_sz = 64; char kbuf[64];
char kbuf[kbuf_sz];
char *tmp; char *tmp;
u64 new_entitled, *new_entitled_ptr = &new_entitled; u64 new_entitled, *new_entitled_ptr = &new_entitled;
u8 new_weight, *new_weight_ptr = &new_weight; u8 new_weight, *new_weight_ptr = &new_weight;
...@@ -595,7 +594,7 @@ static ssize_t lparcfg_write(struct file *file, const char __user * buf, ...@@ -595,7 +594,7 @@ static ssize_t lparcfg_write(struct file *file, const char __user * buf,
if (!firmware_has_feature(FW_FEATURE_SPLPAR)) if (!firmware_has_feature(FW_FEATURE_SPLPAR))
return -EINVAL; return -EINVAL;
if (count > kbuf_sz) if (count > sizeof(kbuf))
return -EINVAL; return -EINVAL;
if (copy_from_user(kbuf, buf, count)) if (copy_from_user(kbuf, buf, count))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment