Commit 74d443bb authored by Somya Anand's avatar Somya Anand Committed by Greg Kroah-Hartman

staging: android: logger: Add a TODO

A comment about a pre-existing bug data structure definition is added.
This bug was evidently introduced by Xiong Zhou in the patch
bd471258 ("staging: android: logger: use kuid_t instead of uid_t")
where the code was changed to hide a valid build warning instead of
solving the bug that was identified by it.
Signed-off-by: default avatarSomya Anand <somyaanand214@gmail.com>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2adc8c46
...@@ -5,6 +5,13 @@ TODO: ...@@ -5,6 +5,13 @@ TODO:
- make sure things build as modules properly - make sure things build as modules properly
- add proper arch dependencies as needed - add proper arch dependencies as needed
- audit userspace interfaces to make sure they are sane - audit userspace interfaces to make sure they are sane
- kuid_t should never be exposed to user space as it is
kernel internal type. Data structure for this kuid_t is:
typedef struct {
uid_t val;
} kuid_t;
- This bug is introduced by Xiong Zhou in the patch bd471258f2e09
- ("staging: android: logger: use kuid_t instead of uid_t")
Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc: Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc:
Brian Swetland <swetland@google.com> Brian Swetland <swetland@google.com>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment