Commit 752c938a authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown

ASoC: topology: Fix a signedness bug in soc_tplg_dapm_widget_create()

The "template.id" variable is an enum and in this context GCC will
treat it as an unsigned int so it can never be less than zero.

Fixes: 8a978234 ("ASoC: topology: Add topology core")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20190925110624.GR3264@mwandaSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 901e822b
...@@ -1588,7 +1588,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg, ...@@ -1588,7 +1588,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
/* map user to kernel widget ID */ /* map user to kernel widget ID */
template.id = get_widget_id(le32_to_cpu(w->id)); template.id = get_widget_id(le32_to_cpu(w->id));
if (template.id < 0) if ((int)template.id < 0)
return template.id; return template.id;
/* strings are allocated here, but used and freed by the widget */ /* strings are allocated here, but used and freed by the widget */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment