Commit 752d48b5 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller

bonding: move active_slave getting into separate function

Signed-off-by: default avatarJiri Pirko <jiri@resnulli.us>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 080a06e1
...@@ -57,6 +57,24 @@ int bond_option_mode_set(struct bonding *bond, int mode) ...@@ -57,6 +57,24 @@ int bond_option_mode_set(struct bonding *bond, int mode)
return 0; return 0;
} }
static struct net_device *__bond_option_active_slave_get(struct bonding *bond,
struct slave *slave)
{
return USES_PRIMARY(bond->params.mode) && slave ? slave->dev : NULL;
}
struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond)
{
struct slave *slave = rcu_dereference(bond->curr_active_slave);
return __bond_option_active_slave_get(bond, slave);
}
struct net_device *bond_option_active_slave_get(struct bonding *bond)
{
return __bond_option_active_slave_get(bond, bond->curr_active_slave);
}
int bond_option_active_slave_set(struct bonding *bond, int bond_option_active_slave_set(struct bonding *bond,
struct net_device *slave_dev) struct net_device *slave_dev)
{ {
......
...@@ -1219,13 +1219,13 @@ static ssize_t bonding_show_active_slave(struct device *d, ...@@ -1219,13 +1219,13 @@ static ssize_t bonding_show_active_slave(struct device *d,
char *buf) char *buf)
{ {
struct bonding *bond = to_bond(d); struct bonding *bond = to_bond(d);
struct slave *curr; struct net_device *slave_dev;
int count = 0; int count = 0;
rcu_read_lock(); rcu_read_lock();
curr = rcu_dereference(bond->curr_active_slave); slave_dev = bond_option_active_slave_get_rcu(bond);
if (USES_PRIMARY(bond->params.mode) && curr) if (slave_dev)
count = sprintf(buf, "%s\n", curr->dev->name); count = sprintf(buf, "%s\n", slave_dev->name);
rcu_read_unlock(); rcu_read_unlock();
return count; return count;
......
...@@ -428,6 +428,8 @@ int bond_netlink_init(void); ...@@ -428,6 +428,8 @@ int bond_netlink_init(void);
void bond_netlink_fini(void); void bond_netlink_fini(void);
int bond_option_mode_set(struct bonding *bond, int mode); int bond_option_mode_set(struct bonding *bond, int mode);
int bond_option_active_slave_set(struct bonding *bond, struct net_device *slave_dev); int bond_option_active_slave_set(struct bonding *bond, struct net_device *slave_dev);
struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond);
struct net_device *bond_option_active_slave_get(struct bonding *bond);
struct bond_net { struct bond_net {
struct net * net; /* Associated network namespace */ struct net * net; /* Associated network namespace */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment