Commit 77f4689d authored by Al Viro's avatar Al Viro

fix regression in "epoll: Keep a reference on files added to the check list"

epoll_loop_check_proc() can run into a file already committed to destruction;
we can't grab a reference on those and don't need to add them to the set for
reverse path check anyway.
Tested-by: default avatarMarc Zyngier <maz@kernel.org>
Fixes: a9ed4a65 ("epoll: Keep a reference on files added to the check list")
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 52c47969
...@@ -1995,9 +1995,9 @@ static int ep_loop_check_proc(void *priv, void *cookie, int call_nests) ...@@ -1995,9 +1995,9 @@ static int ep_loop_check_proc(void *priv, void *cookie, int call_nests)
* during ep_insert(). * during ep_insert().
*/ */
if (list_empty(&epi->ffd.file->f_tfile_llink)) { if (list_empty(&epi->ffd.file->f_tfile_llink)) {
get_file(epi->ffd.file); if (get_file_rcu(epi->ffd.file))
list_add(&epi->ffd.file->f_tfile_llink, list_add(&epi->ffd.file->f_tfile_llink,
&tfile_check_list); &tfile_check_list);
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment