Commit 7829a0c1 authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu

crypto: hmac - fix memory leak in hmac_init_tfm()

When I added the sanity check of 'descsize', I missed that the child
hash tfm needs to be freed if the sanity check fails.  Of course this
should never happen, hence the use of WARN_ON(), but it should be fixed.

Fixes: e1354400 ("crypto: hash - fix incorrect HASH_MAX_DESCSIZE")
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 9c5b34c2
...@@ -157,8 +157,10 @@ static int hmac_init_tfm(struct crypto_tfm *tfm) ...@@ -157,8 +157,10 @@ static int hmac_init_tfm(struct crypto_tfm *tfm)
parent->descsize = sizeof(struct shash_desc) + parent->descsize = sizeof(struct shash_desc) +
crypto_shash_descsize(hash); crypto_shash_descsize(hash);
if (WARN_ON(parent->descsize > HASH_MAX_DESCSIZE)) if (WARN_ON(parent->descsize > HASH_MAX_DESCSIZE)) {
crypto_free_shash(hash);
return -EINVAL; return -EINVAL;
}
ctx->hash = hash; ctx->hash = hash;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment