Commit 79cd874c authored by stephen hemminger's avatar stephen hemminger Committed by David S. Miller

netvsc: fix hang on netvsc module removal

The code in netvsc_device_remove was incorrectly calling napi_disable
repeatedly on the same element. This would cause attempts
to remove netvsc module to hang.

Fixes: 2506b1dc4bbe ("netvsc: implement NAPI")
Signed-off-by: default avatarStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0d6dd357
...@@ -562,8 +562,8 @@ void netvsc_device_remove(struct hv_device *device) ...@@ -562,8 +562,8 @@ void netvsc_device_remove(struct hv_device *device)
/* Now, we can close the channel safely */ /* Now, we can close the channel safely */
vmbus_close(device->channel); vmbus_close(device->channel);
for (i = 0; i < VRSS_CHANNEL_MAX; i++) for (i = 0; i < net_device->num_chn; i++)
napi_disable(&net_device->chan_table[0].napi); napi_disable(&net_device->chan_table[i].napi);
/* Release all resources */ /* Release all resources */
free_netvsc_device(net_device); free_netvsc_device(net_device);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment