Commit 7b09777c authored by Rob Herring's avatar Rob Herring Committed by Ralf Baechle

MIPS: Add struct pci_ops member names to initialization

Some instances of pci_ops initialization rely on the read/write members'
location in the struct. This is fragile and may break when adding new
members to the beginning of the struct.

[ralf@linux-mips.org: indent = with tabs for consistency.]
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Patchwork: https://patchwork.linux-mips.org/patch/8915/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 250215cc
...@@ -173,8 +173,8 @@ static int bcm1480_pcibios_write(struct pci_bus *bus, unsigned int devfn, ...@@ -173,8 +173,8 @@ static int bcm1480_pcibios_write(struct pci_bus *bus, unsigned int devfn,
} }
struct pci_ops bcm1480_pci_ops = { struct pci_ops bcm1480_pci_ops = {
bcm1480_pcibios_read, .read = bcm1480_pcibios_read,
bcm1480_pcibios_write, .write = bcm1480_pcibios_write,
}; };
static struct resource bcm1480_mem_resource = { static struct resource bcm1480_mem_resource = {
......
...@@ -327,8 +327,8 @@ static int octeon_write_config(struct pci_bus *bus, unsigned int devfn, ...@@ -327,8 +327,8 @@ static int octeon_write_config(struct pci_bus *bus, unsigned int devfn,
static struct pci_ops octeon_pci_ops = { static struct pci_ops octeon_pci_ops = {
octeon_read_config, .read = octeon_read_config,
octeon_write_config, .write = octeon_write_config,
}; };
static struct resource octeon_pci_mem_resource = { static struct resource octeon_pci_mem_resource = {
......
...@@ -1792,8 +1792,8 @@ static int octeon_dummy_write_config(struct pci_bus *bus, unsigned int devfn, ...@@ -1792,8 +1792,8 @@ static int octeon_dummy_write_config(struct pci_bus *bus, unsigned int devfn,
} }
static struct pci_ops octeon_pcie0_ops = { static struct pci_ops octeon_pcie0_ops = {
octeon_pcie0_read_config, .read = octeon_pcie0_read_config,
octeon_pcie0_write_config, .write = octeon_pcie0_write_config,
}; };
static struct resource octeon_pcie0_mem_resource = { static struct resource octeon_pcie0_mem_resource = {
...@@ -1813,8 +1813,8 @@ static struct pci_controller octeon_pcie0_controller = { ...@@ -1813,8 +1813,8 @@ static struct pci_controller octeon_pcie0_controller = {
}; };
static struct pci_ops octeon_pcie1_ops = { static struct pci_ops octeon_pcie1_ops = {
octeon_pcie1_read_config, .read = octeon_pcie1_read_config,
octeon_pcie1_write_config, .write = octeon_pcie1_write_config,
}; };
static struct resource octeon_pcie1_mem_resource = { static struct resource octeon_pcie1_mem_resource = {
...@@ -1834,8 +1834,8 @@ static struct pci_controller octeon_pcie1_controller = { ...@@ -1834,8 +1834,8 @@ static struct pci_controller octeon_pcie1_controller = {
}; };
static struct pci_ops octeon_dummy_ops = { static struct pci_ops octeon_dummy_ops = {
octeon_dummy_read_config, .read = octeon_dummy_read_config,
octeon_dummy_write_config, .write = octeon_dummy_write_config,
}; };
static struct resource octeon_dummy_mem_resource = { static struct resource octeon_dummy_mem_resource = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment