Commit 7b659ee3 authored by Dave Hansen's avatar Dave Hansen Committed by Ingo Molnar

x86/pkeys/selftests: Fix protection keys write() warning

write() is marked as having a must-check return value.  Check it and
abort if we fail to write an error message from a signal handler.
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20171111001232.94813E58@viggo.jf.intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 91c49c2d
...@@ -30,6 +30,7 @@ static inline void sigsafe_printf(const char *format, ...) ...@@ -30,6 +30,7 @@ static inline void sigsafe_printf(const char *format, ...)
if (!dprint_in_signal) { if (!dprint_in_signal) {
vprintf(format, ap); vprintf(format, ap);
} else { } else {
int ret;
int len = vsnprintf(dprint_in_signal_buffer, int len = vsnprintf(dprint_in_signal_buffer,
DPRINT_IN_SIGNAL_BUF_SIZE, DPRINT_IN_SIGNAL_BUF_SIZE,
format, ap); format, ap);
...@@ -39,7 +40,9 @@ static inline void sigsafe_printf(const char *format, ...) ...@@ -39,7 +40,9 @@ static inline void sigsafe_printf(const char *format, ...)
*/ */
if (len > DPRINT_IN_SIGNAL_BUF_SIZE) if (len > DPRINT_IN_SIGNAL_BUF_SIZE)
len = DPRINT_IN_SIGNAL_BUF_SIZE; len = DPRINT_IN_SIGNAL_BUF_SIZE;
write(1, dprint_in_signal_buffer, len); ret = write(1, dprint_in_signal_buffer, len);
if (ret < 0)
abort();
} }
va_end(ap); va_end(ap);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment