Commit 7e4d4233 authored by Vaibhav Jain's avatar Vaibhav Jain Committed by Michael Ellerman

powerpc: Do not assign thread.tidr if already assigned

If set_thread_tidr() is called twice for same task_struct then it will
allocate a new tidr value to it leaving the previous value still
dangling in the vas_thread_ida table.

To fix this the patch changes set_thread_tidr() to check if a tidr
value is already assigned to the task_struct and if yes then returns
zero.

Fixes: ec233ede("powerpc: Add support for setting SPRN_TIDR")
Signed-off-by: default avatarVaibhav Jain <vaibhav@linux.vnet.ibm.com>
Reviewed-by: default avatarAndrew Donnellan <andrew.donnellan@au1.ibm.com>
[mpe: Modify to return 0 in the success case, not the TID value]
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent aca7573f
...@@ -1577,6 +1577,9 @@ int set_thread_tidr(struct task_struct *t) ...@@ -1577,6 +1577,9 @@ int set_thread_tidr(struct task_struct *t)
if (t != current) if (t != current)
return -EINVAL; return -EINVAL;
if (t->thread.tidr)
return 0;
rc = assign_thread_tidr(); rc = assign_thread_tidr();
if (rc < 0) if (rc < 0)
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment