Commit 7e51f197 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

checkpatch: check for duplicate signatures

Emit a warning when a signature is used more than once.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d62a201f
...@@ -1544,6 +1544,7 @@ sub process { ...@@ -1544,6 +1544,7 @@ sub process {
my %suppress_export; my %suppress_export;
my $suppress_statement = 0; my $suppress_statement = 0;
my %signatures = ();
# Pre-scan the patch sanitizing the lines. # Pre-scan the patch sanitizing the lines.
# Pre-scan the patch looking for any __setup documentation. # Pre-scan the patch looking for any __setup documentation.
...@@ -1793,6 +1794,17 @@ sub process { ...@@ -1793,6 +1794,17 @@ sub process {
"email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr); "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
} }
} }
# Check for duplicate signatures
my $sig_nospace = $line;
$sig_nospace =~ s/\s//g;
$sig_nospace = lc($sig_nospace);
if (defined $signatures{$sig_nospace}) {
WARN("BAD_SIGN_OFF",
"Duplicate signature\n" . $herecurr);
} else {
$signatures{$sig_nospace} = 1;
}
} }
# Check for wrappage within a valid hunk of the file # Check for wrappage within a valid hunk of the file
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment