Commit 7e7eb434 authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher

ixgbe: remove timer reset to 0 on timeout

The VF mailbox polling for acks and messages would reset the timer to zero
on a timeout. Under heavy load a timeout may actually occur without being
the result of an error and when this occurs it is not practical to perform
a full VF driver reset on every message timeout. Instead, just return an
error (which is already done) and the VF driver will have an opportunity
to retry the operation.
Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Acked-by: default avatarGreg Rose <gregory.v.rose@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent c27931da
...@@ -154,9 +154,6 @@ static s32 ixgbe_poll_for_msg(struct ixgbe_hw *hw, u16 mbx_id) ...@@ -154,9 +154,6 @@ static s32 ixgbe_poll_for_msg(struct ixgbe_hw *hw, u16 mbx_id)
udelay(mbx->usec_delay); udelay(mbx->usec_delay);
} }
/* if we failed, all future posted messages fail until reset */
if (!countdown)
mbx->timeout = 0;
out: out:
return countdown ? 0 : IXGBE_ERR_MBX; return countdown ? 0 : IXGBE_ERR_MBX;
} }
...@@ -183,9 +180,6 @@ static s32 ixgbe_poll_for_ack(struct ixgbe_hw *hw, u16 mbx_id) ...@@ -183,9 +180,6 @@ static s32 ixgbe_poll_for_ack(struct ixgbe_hw *hw, u16 mbx_id)
udelay(mbx->usec_delay); udelay(mbx->usec_delay);
} }
/* if we failed, all future posted messages fail until reset */
if (!countdown)
mbx->timeout = 0;
out: out:
return countdown ? 0 : IXGBE_ERR_MBX; return countdown ? 0 : IXGBE_ERR_MBX;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment