Commit 7f05b245 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab

[media] tuners/tda18271: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 03c42001
...@@ -1290,13 +1290,11 @@ int tda18271_assign_map_layout(struct dvb_frontend *fe) ...@@ -1290,13 +1290,11 @@ int tda18271_assign_map_layout(struct dvb_frontend *fe)
switch (priv->id) { switch (priv->id) {
case TDA18271HDC1: case TDA18271HDC1:
priv->maps = &tda18271c1_map_layout; priv->maps = &tda18271c1_map_layout;
memcpy(&priv->std, &tda18271c1_std_map, priv->std = tda18271c1_std_map;
sizeof(struct tda18271_std_map));
break; break;
case TDA18271HDC2: case TDA18271HDC2:
priv->maps = &tda18271c2_map_layout; priv->maps = &tda18271c2_map_layout;
memcpy(&priv->std, &tda18271c2_std_map, priv->std = tda18271c2_std_map;
sizeof(struct tda18271_std_map));
break; break;
default: default:
ret = -EINVAL; ret = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment