Commit 7f736599 authored by Huang Zijiang's avatar Huang Zijiang Committed by Borislav Petkov

EDAC, altera: Add missing of_node_put()

The call to of_parse_phandle() returns a node pointer with refcount
incremented thus it must be explicitly decremented here after the last
usage.
Signed-off-by: default avatarHuang Zijiang <huang.zijiang@zte.com.cn>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Reviewed-by: default avatarThor Thayer <thor.thayer@linux.intel.com>
Cc: James Morse <james.morse@arm.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: wang.yi59@zte.com.cn
Link: https://lkml.kernel.org/r/1550126347-27984-1-git-send-email-huang.zijiang@zte.com.cn
parent cbfa482f
...@@ -1046,14 +1046,17 @@ altr_init_a10_ecc_block(struct device_node *np, u32 irq_mask, ...@@ -1046,14 +1046,17 @@ altr_init_a10_ecc_block(struct device_node *np, u32 irq_mask,
return -ENODEV; return -ENODEV;
} }
if (of_address_to_resource(sysmgr_np, 0, &res)) if (of_address_to_resource(sysmgr_np, 0, &res)) {
of_node_put(sysmgr_np);
return -ENOMEM; return -ENOMEM;
}
/* Need physical address for SMCC call */ /* Need physical address for SMCC call */
base = res.start; base = res.start;
ecc_mgr_map = regmap_init(NULL, NULL, (void *)base, ecc_mgr_map = regmap_init(NULL, NULL, (void *)base,
&s10_sdram_regmap_cfg); &s10_sdram_regmap_cfg);
of_node_put(sysmgr_np);
} }
of_node_put(np_eccmgr); of_node_put(np_eccmgr);
if (IS_ERR(ecc_mgr_map)) { if (IS_ERR(ecc_mgr_map)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment