Commit 8131a246 authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz Committed by Eduardo Valentin

thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

Remove runtime checks for negative return values of temp_to_code()
from exynos_tmu_initialize().

The current level temperature data hardcoded in pdata will never
cause a negative temp_to_code() return values and checking itself
is not proper.  The checks in question are done at runtime in
a production code for data that is hardcoded inside driver during
development time and later it doesn't change.  Such data should
be verified during development and review time (i.e. by a script
parsing relevant data from exynos_tmu_data.c, one can also argue
that verification to be done is so simple that the review by
a maintainer should be enough).

Theres should be no functional changes caused by this patch.
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Tested-by: default avatarAmit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent 930aa102
...@@ -215,10 +215,6 @@ static int exynos_tmu_initialize(struct platform_device *pdev) ...@@ -215,10 +215,6 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
if (data->soc == SOC_ARCH_EXYNOS4210) { if (data->soc == SOC_ARCH_EXYNOS4210) {
/* Write temperature code for threshold */ /* Write temperature code for threshold */
threshold_code = temp_to_code(data, pdata->threshold); threshold_code = temp_to_code(data, pdata->threshold);
if (threshold_code < 0) {
ret = threshold_code;
goto out;
}
writeb(threshold_code, writeb(threshold_code,
data->base + reg->threshold_temp); data->base + reg->threshold_temp);
for (i = 0; i < trigger_levs; i++) for (i = 0; i < trigger_levs; i++)
...@@ -232,19 +228,13 @@ static int exynos_tmu_initialize(struct platform_device *pdev) ...@@ -232,19 +228,13 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
i < trigger_levs && i < EXYNOS_MAX_TRIGGER_PER_REG; i++) { i < trigger_levs && i < EXYNOS_MAX_TRIGGER_PER_REG; i++) {
threshold_code = temp_to_code(data, threshold_code = temp_to_code(data,
pdata->trigger_levels[i]); pdata->trigger_levels[i]);
if (threshold_code < 0) {
ret = threshold_code;
goto out;
}
rising_threshold &= ~(0xff << 8 * i); rising_threshold &= ~(0xff << 8 * i);
rising_threshold |= threshold_code << 8 * i; rising_threshold |= threshold_code << 8 * i;
if (pdata->threshold_falling) { if (pdata->threshold_falling) {
threshold_code = temp_to_code(data, threshold_code = temp_to_code(data,
pdata->trigger_levels[i] - pdata->trigger_levels[i] -
pdata->threshold_falling); pdata->threshold_falling);
if (threshold_code > 0) falling_threshold |= threshold_code << 8 * i;
falling_threshold |=
threshold_code << 8 * i;
} }
} }
...@@ -263,10 +253,6 @@ static int exynos_tmu_initialize(struct platform_device *pdev) ...@@ -263,10 +253,6 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
(pdata->trigger_type[i] == HW_TRIP)) { (pdata->trigger_type[i] == HW_TRIP)) {
threshold_code = temp_to_code(data, threshold_code = temp_to_code(data,
pdata->trigger_levels[i]); pdata->trigger_levels[i]);
if (threshold_code < 0) {
ret = threshold_code;
goto out;
}
if (i == EXYNOS_MAX_TRIGGER_PER_REG - 1) { if (i == EXYNOS_MAX_TRIGGER_PER_REG - 1) {
/* 1-4 level to be assigned in th0 reg */ /* 1-4 level to be assigned in th0 reg */
rising_threshold &= ~(0xff << 8 * i); rising_threshold &= ~(0xff << 8 * i);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment