Commit 81a08382 authored by Dan Carpenter's avatar Dan Carpenter Committed by Anton Vorontsov

isp1704_charger: Use after free on probe error

We can't use "isp" after freeing it.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarFelipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: default avatarAnton Vorontsov <anton.vorontsov@linaro.org>
parent 13f2483c
...@@ -474,13 +474,13 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev) ...@@ -474,13 +474,13 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
fail2: fail2:
power_supply_unregister(&isp->psy); power_supply_unregister(&isp->psy);
fail1: fail1:
isp1704_charger_set_power(isp, 0);
usb_put_transceiver(isp->phy); usb_put_transceiver(isp->phy);
fail0: fail0:
kfree(isp); kfree(isp);
dev_err(&pdev->dev, "failed to register isp1704 with error %d\n", ret); dev_err(&pdev->dev, "failed to register isp1704 with error %d\n", ret);
isp1704_charger_set_power(isp, 0);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment