Commit 83785733 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen

scsi: libcxgbi: remove uninitialized variable len

The variable len is not being inintialized and the uninitialized value is
being returned. However, this return path is never reached because the
default case in the switch statement returns -ENOSYS.  Clean up the code by
replacing the return -ENOSYS with a break for the default case and
returning -ENOSYS at the end of the function.  This allows len to be
removed.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 82129697
...@@ -2310,7 +2310,6 @@ int cxgbi_get_ep_param(struct iscsi_endpoint *ep, enum iscsi_param param, ...@@ -2310,7 +2310,6 @@ int cxgbi_get_ep_param(struct iscsi_endpoint *ep, enum iscsi_param param,
{ {
struct cxgbi_endpoint *cep = ep->dd_data; struct cxgbi_endpoint *cep = ep->dd_data;
struct cxgbi_sock *csk; struct cxgbi_sock *csk;
int len;
log_debug(1 << CXGBI_DBG_ISCSI, log_debug(1 << CXGBI_DBG_ISCSI,
"cls_conn 0x%p, param %d.\n", ep, param); "cls_conn 0x%p, param %d.\n", ep, param);
...@@ -2328,9 +2327,9 @@ int cxgbi_get_ep_param(struct iscsi_endpoint *ep, enum iscsi_param param, ...@@ -2328,9 +2327,9 @@ int cxgbi_get_ep_param(struct iscsi_endpoint *ep, enum iscsi_param param,
return iscsi_conn_get_addr_param((struct sockaddr_storage *) return iscsi_conn_get_addr_param((struct sockaddr_storage *)
&csk->daddr, param, buf); &csk->daddr, param, buf);
default: default:
return -ENOSYS; break;
} }
return len; return -ENOSYS;
} }
EXPORT_SYMBOL_GPL(cxgbi_get_ep_param); EXPORT_SYMBOL_GPL(cxgbi_get_ep_param);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment